fix: fee estimation error #4832
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fbwoolf
force-pushed
the
fix/fee-estimation-error
branch
from
8121ffe to
d29c19f
Compare
kyranjamie
approved these changes
Jan 21, 2024
There was a problem hiding this comment.
Thanks for taking on Fara. I reckon it'd be better to change the fetcher to handle (rather than preventing access to query hook,like https://stackoverflow.com/a/73141514). What do you reckon?
But otherwise LGTM
I can try to move it there today, np. |
fbwoolf
force-pushed
the
fix/fee-estimation-error
branch
from
d29c19f to
9c072f7
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR should return the default min capped values for Stacks tx fee estimations if the query errors with a log message. I did not see that you can return the data in the
onErrorfunction, so I created a new hook just to handle when the data isundefined...that is what I was seeing when debugging this, but let me know if this is not what has been reported.